Perhaps not so useless.
Part of the Logjam/WeakDH findings, for example, was that the widespread use of a handful of "weak" finite-field DH groups for TLS key exchange meant a large corpus of captured encrypted data was becoming accessible for targeted decryption. So there are real-world cases where improvements in attacks make some of that stored data available.
Similarly, the current plausible risk to encryption from QC is not real-time decryption of data in transit — that looks far too expensive even into the foreseeable future, even assuming we see major advancement in QEC and scaling. What does start to become feasible with such advancement is targeted decryption (of session keys encrypted with RSA, finite-field DH, and ECC DH) for specific previously-recorded messages deemed to be of particular interest. So the DHS decides it's interested in messages exchanged between parties X and Y around timestamp Z, the NSA pulls just those from the corpus, breaks the asymmetric keys (with this hypothetical big-enough-to-be-useful QC), gets the session key, and decrypts just those messages.
Or consider ROBOT/MARVIN: If you've sniffed a bunch of traffic that used a particular RSA pair for Kx, and then you find updated Bleichenbacher attacks work against the server and it's still using that same key pair, then you can derive the private key and go back and decrypt (the session keys for, and then the data of) those stored messages. And similarly for other improved attacks.
While bulk decryption of those vast corpora of data sniffed by various state agencies may well never be possible, targeted decryption just might be. There are still significant obstacles: QC isn't there yet (at least according to published research, and no, I don't believe the NSA or other agencies are that far ahead of the private sector), and while "attacks get better" is a general truism, it's not something you can count on in any specific case. But data hording has been useful to the spooks in the past, and will almost certainly be useful in the future.
Which is not to say I approve of it. I'm just noting the economics of the practice are not, from the governments' points of view, as irrational as you suggest.