Owned multiple Xiaomi phones, and...
continue to recommend them.
Step dad recently bought one to replace his Samsung and is really happy with it.
SWMBO NEARLY bought one, but let a friend talk her into a Huawei P20 Pro instead.
They are selling so well because
a/ they are well made
b/ the spec is as good as many more expensive phones (with 1 or 2 minor omissions)
c/ they keep pushing out software and firmware updates
My oldest Note1 (3G), is all but dead after my 5 y/o broke the USB port (again), it is as old as she is, and was still getting updates, even though the only way to charge it is to take the battery out and use an external charger (which I got for free when ordering a new £2.50 battery for it).